This repository has been archived by the owner on Feb 26, 2022. It is now read-only.
Bug 632572 - CommonJS test adapter #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ('operator' in options) | ||
| assertionError.operator = options.operator; | ||
| assertionError.message = options.message; | ||
| assertionError.stack = new Error().stack; |
There was a problem hiding this comment.
You're right I had to return assertionError
| } | ||
| }, | ||
| /** | ||
| * The equality assertion tests shallow, coercive equality with `=`. |
There was a problem hiding this comment.
Thanks, I've fixed that!
|
As I suggested on the IRC I have modified this pull request to point to a different bug. There for scope of is changed and it only aims to get CommonJS test adapter. |
|
Also I think that code follows all the conventions, if you see where it's not can you please comment inline or post a line number ? |
| // See for details: http://wiki.commonjs.org/wiki/Unit_Testing/1.1 | ||
| let Assert = suite.Assert || BaseAssert; | ||
|
|
||
| // Going through each item in the test suit and wrapping it into a |
|
Not sure why this pull request does not wants to pick up new changes so I made a new one: |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.